Skip to content

[REST API] unit tests for site credentials #8171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

[REST API] unit tests for site credentials #8171

merged 1 commit into from
Jan 13, 2023

Conversation

@hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Jan 12, 2023 •
edited
Loading

Closes: #8110

⚠️ Please don't merge before #8156

Description

This PR adds unit tests for the the site credentials screen, and this includes the changes of these PRs:

@hichamboushaba hichamboushaba added status: do not merge Dependent on another PR, ready for review but not ready for merge. category: unit tests Related to unit testing. feature: REST API Support connecting to sites using WordPress REST API. labels Jan 12, 2023
@hichamboushaba hichamboushaba changed the base branch from trunk to issue/8110-user-role January 12, 2023 09:18
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 12, 2023

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@hichamboushaba hichamboushaba mentioned this pull request Jan 12, 2023
Closed
7 tasks
@hichamboushaba hichamboushaba marked this pull request as ready for review January 12, 2023 10:21
@JorgeMucientes JorgeMucientes self-assigned this Jan 12, 2023
Base automatically changed from issue/8110-user-role to trunk January 13, 2023 11:22
@JorgeMucientes
Copy link
Contributor

JorgeMucientes commented Jan 13, 2023

Well done @hichamboushaba very nice readable tests! 🚢

@JorgeMucientes JorgeMucientes removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jan 13, 2023
@JorgeMucientes JorgeMucientes merged commit f57cb82 into trunk Jan 13, 2023
@JorgeMucientes JorgeMucientes deleted the issue/8110-unit-tests branch January 13, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JorgeMucientes JorgeMucientes JorgeMucientes approved these changes

@hafizrahman hafizrahman Awaiting requested review from hafizrahman

@0nko 0nko Awaiting requested review from 0nko

Assignees

@JorgeMucientes JorgeMucientes

Labels

category: unit tests Related to unit testing. feature: REST API Support connecting to sites using WordPress REST API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REST API] Site Credentials login flow

4 participants

@hichamboushaba @wpmobilebot @JorgeMucientes